-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Aztec 1.19.3 #23805
Integrate Aztec 1.19.3 #23805
Conversation
@@ -39,7 +39,7 @@ target 'gutenberg' do | |||
pod 'Folly', :podspec => '../../../node_modules/react-native/third-party-podspecs/Folly.podspec' | |||
pod 'RNTAztecView', :path => '../../react-native-aztec/RNTAztecView.podspec' | |||
#Use for testing non official versions of Aztec | |||
pod 'WordPress-Aztec-iOS', :git => 'https://github.com/wordpress-mobile/WordPress-Aztec-iOS.git', :commit => '9187001a9c6dc84c211937b1b5a2af2a8b8d54a9' | |||
pod 'WordPress-Aztec-iOS', :git => 'https://github.com/wordpress-mobile/WordPress-Aztec-iOS.git', :tag => '1.19.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You only this reference when testing the changes in Aztec, the moment you update the dependency on the RNTAztecView.podspec file you should comment this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comments about the Podfile and podspec file.
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Description
Fix Build issue with Gutenberg Mobile on iOS
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist: